Fix 'ValueError' in 'ct2-opennmt-py-converter' for Unsupported '--self_attn_type' #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, my message on the forum was a hack not really a fix. |
Member
|
closing in favor of #1687 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request resolves a ValueError when converting OpenNMT models to CTranslate2 using ct2-opennmt-py-converter. The issue was due to unsupported --self_attn_type scaled-dot-flash, with only scaled-dot being supported.
Solution:
Implemented a fix based on a suggestion from a discussion by vince62s on the OpenNMT forum, which successfully addresses the conversion issue.
Testing:
Verified the fix by converting models that previously triggered the error, ensuring the process now completes without issues.
Reference:
Solution inspired by a post on OpenNMT Forum.
This update should help users facing similar conversion problems.